New subtitle support - Githubissues

Opencast-Moodle / moodle-mod_opencast

Opencast Activity that can display series and episodes from Opencast. The authentication is fully handled by Moodle.

Other

4 stars 7 forks source link

New subtitle support #49

Open ferishili opened 6 months ago

ferishili commented 6 months ago

This PR fixes #48

Description

In Opencast 15, captions (subtitles) are provided with different format as for their flavors: captions/delivery ... etc. and every other data including language code etc. is included in the tags.

Solution

This patch covers the new subtitles format while it maintain the old ones.
The get_caption function now cover attachments and media and for media also looks for old and new subtitles.

To TEST

You would need to have Opencast 15.
You would need to have auto generated captions as well as manually uploaded caption via block_opencast plugin (or any other way) in order to test all cases.
Try to watch the event via this plugin or in filter plugin
All captions must be accessible in the paella player!

mwuttke commented 6 months ago

Hello @ferishili, I tested videos with subtitles created by amberscript in english & in german with in the mod plugin, embedded in a page and embedded in a book page. And I tested videos with subtitles created by whisper and by whipsercpp in english & in german with in the mod plugin, embedded in a page and in a book page. In all scenarios the subtitles where shown. So the patch works for me. ;-)

We used for the test scenarios Opencast Version 15.3 and Moodle Version 4.1.9+.

mwuttke commented 3 months ago

@NinaHerrmann & @justusdieckmann, what do you think speaks against reviewing and releasing this PR?

NinaHerrmann commented 3 months ago

We do not have the capacity to review it.

ferishili commented 2 months ago

Hi @justusdieckmann, The changes are applied.

Unfortunately, I have very little knowledge about automatic captions, but I would guess these docs could help!

https://docs.opencast.org/r/15.x/admin/#configuration/transcription.configuration/whisper/ https://docs.opencast.org/r/15.x/admin/#configuration/transcription.configuration/vosk/