the Fraunhofer AAC lib is fdk-aac, not fdk-aac-dabplus - which is our OpenDigitalradio AAC encoder ;-)
FAAD2 should not be REQUIRED as someone may choose to use fdk-aac instead (besides, the REQUIRED check did not work for me, as CMake did not abort when I previously removed FAAD2 for testing - although the later if check worked of course)
the fec lib can be included via ${FEC_LIBRARIES} (instead of ${FEC}) and the lone fec therefore removed
IMO the dablin_gtk target should only be created/compiled/installed when gtkmm ist installed (GTKMM therefore should not be REQUIRED, so that CLI only people do not have to install gtkmm)
Thanks for your PR - this is a great improvement compared to the current Makefile.
I took a look into the commits and identified some minor issues, so I would like to suggest the following fixes:
dablin.cpp
- the sources lists should rather look e.g. like the following:fdk-aac
, notfdk-aac-dabplus
- which is our OpenDigitalradio AAC encoder ;-)REQUIRED
as someone may choose to use fdk-aac instead (besides, theREQUIRED
check did not work for me, as CMake did not abort when I previously removed FAAD2 for testing - although the laterif
check worked of course)fec
lib can be included via${FEC_LIBRARIES}
(instead of${FEC}
) and the lonefec
therefore removeddablin_gtk
target should only be created/compiled/installed when gtkmm ist installed (GTKMM
therefore should not beREQUIRED
, so that CLI only people do not have to install gtkmm)