search

Opendigitalradio / dablin

DAB/DAB+ receiver for Linux (including ETI-NI and EDI AF playback)
GNU General Public License v3.0
123 stars 27 forks source link

Rearrange the source code, and other changes #12

Closed russel closed 7 years ago

russel commented 7 years ago

So as to enable bringing in a "vendor fork" of the ka9q-fec library, and to add tests to the codebase, I propose creating a src directory and moving all the current source for dablin and dablin_gtk to there.

I propose abandoning the current Makefile system.

Given the Gtk+3 element here do we want a Meson build to exist in parallel with the CMake build. (Having the CMake build is currently critical to be able to use CLion (https://www.jetbrains.com/clion/) for development, but many Gtk+3 projects are abandoning Autotools and Make in favour of Meson, and Ninja).

basicmaster commented 7 years ago

A src directory indeed makes sense.

Tests are good but I wonder how to test an application like this, as this is not e.g. a conversion tool where one could simply compare the intended output with the actual one and play with the parameters. So testing seems rather difficult at least to me. But if there is nevertheless a good way to do testing, why not.

Yes, removal of the Makefile system is kind of overdue since CMake works well. Thus reducing to one wide-spread build system it is sufficient to stay with that system in my opinion.

russel commented 7 years ago

I think the issues in this issue have all been covered by committed pull requests, so I shal close it.