DABlin GTK Icons on macOS

Opendigitalradio / dablin

DAB/DAB+ receiver for Linux (including ETI-NI and EDI AF playback)

GNU General Public License v3.0

123 stars 27 forks source link

DABlin GTK Icons on macOS #52

Closed npm-sdr closed 5 years ago

npm-sdr commented 5 years ago

Hi Stefan,

A long time ago you spotted that the icons were missing from macOS version of DABlin. I Just spent a bit of time this evening to get the icons working.

It turns out that installing gtkmm+3 doesn't install the icons. To get the icons, I had to install "adwaita-icon-theme" package (`brew install adwaita-icon-theme').

Can I update README.md with macOS instructions?

I've attached a screenshot of DABlin on macOS.

Regards, Niro.

basicmaster commented 5 years ago

Hi Niro,

interesting that the icons are not available in the actual GTK package and require a separate package. How did you find out?

I wonder if this is a missing dependency in the package sources and whether it would therefore make sense to fix this on distribution/homebrew side. So also other affected tools using GTK would be fixed. Did you check that by chance?

Besides that it definitely makes sense to add a new subsection to the compilation section to also cover MacOS. Depending on whether there are many differences compared to the default (linux) case, it could make sense to just mention the differences or instead add step-by-step instructions for building. Please feel free to open a merge request on this.

npm-sdr commented 5 years ago

Hi Stefan,

I only found this out by first checking how the icons were implemented in the code and then trying to find the Homebrew packages that included those icon files. I expected gtkmm to have a dependancy on adwaita-icon-theme but it doesn't and I haven't had time to dig any deeper on this.

All build instructions are identical for macOS, given that it's just BSD. I've added a sub-section for development environment and development library installation. Please see attached patch for README.md on the next branch.

dablin-branch_next-README_macOS_instructions.patch.txt

basicmaster commented 5 years ago

As the Windows instructions come a bit later, I put the macOS instructions below them. I also made some minor changes (indent, typos). Thank you for your patch!