Opendigitalradio / dablin

DAB/DAB+ receiver for Linux (including ETI-NI and EDI AF playback)
GNU General Public License v3.0
123 stars 27 forks source link

Mention prerequisites for FAAD2 in Ubuntu 20.04 #70

Closed andimik closed 2 years ago

andimik commented 3 years ago

Resolving autogen.sh: aclocal: not found output when installing in fresh Ubuntu 20.04 environment.

Found the solution in https://kerneltalks.com/troubleshooting/how-to-resolve-aclocal-not-found-error-in-ubuntu/

basicmaster commented 2 years ago

Thanks for your PR.

Some nitpicking :wink:

The word "prerequisitions" does not exist - presumably you meant "prerequisites". On this occasion please also write "FAAD2" in uppercase.

The commit text mentions autogen.sh. However this was the script name used in the example link. For FAAD2 it is ./bootstrap instead.

Actually automake has autotools-dev as a dependency, so the latter is installed automatically if the first one is installed. So it is not necessary to explicitely mention autotools in the text and in the apt-get command.

The last change adds the remark "for Ubuntu 20.04 please see above". As the Ubuntu 20.04 FAAD2 part has to be considered in addition to the generic procedure, the word "also" should be added here.

andimik commented 2 years ago

ok, changed.

The commit text mentions autogen.sh.

This is the output you see in the console, it's not my text.

basicmaster commented 2 years ago

ok, changed.

Thanks

The commit text mentions autogen.sh.

This is the output you see in the console, it's not my text.

This is your commit, refering to autogen.sh: https://github.com/andimik/dablin/commit/edf6f84948387321dfb958b6d4973ffc298db3a9

This is the actual console output when compiling FAAD2 on one's own, refering to ./bootstrap: grafik

basicmaster commented 2 years ago

I'm not sure whether you are going to check the console output on your side....

I suggest to squash all three commits into a single commit with the fixed commit description and to merge it.

basicmaster commented 2 years ago

Adding a squashed commit with all changes to next, as suggested.