search

Opendigitalradio / dabtools

DAB/DAB+ software for RTL-SDR dongles and the Psion Wavefinder including ETI stream recording. This project is currently unmaintained.
GNU General Public License v3.0
17 stars 11 forks source link

Optimizations #1

Closed basicmaster closed 7 years ago

basicmaster commented 7 years ago

(just copied from my PR to linuxstb/dabtools)

Fixes a read error when non-live sources are used (e.g. cat), as read() then does not return 6144 bytes at once but smaller portions. Furthermore distinguish between read error and EOF.

I just changed the circular buffer in order to read/write multiple bytes instead of a single byte which leads to a significant improvement for me.

kylegordon commented 7 years ago

It builds, so that's a :+1: from me

russel commented 7 years ago

I think the moral here though is we need a CI and some tests. I guess a Travis-CI build is in order.

mpbraendli commented 7 years ago

There you go, I'll let you take care of the .travis.yml https://travis-ci.org/Opendigitalradio/dabtools

kylegordon commented 7 years ago

Can do. BRB

russel commented 7 years ago

@kylegordon Looks like we are both half way through creating a .travis.yml and they are a bit different. Not sure how to do the collaborative thing on this.

kylegordon commented 7 years ago

I joined the gitter.im group to see if you were there for a chat, but it all seems a bit quiet. Not to worry though, I think you have it the better/correct way with a cmake based build, rather than the make route I was progressing down. afaict it keeps it more in line with the rest of ODR projects.

russel commented 7 years ago

Ah. I better join that group. I think CMake is the right way for consistency, so I am going to remove the Make stuff for the avoidance of doubt. I really like Meson, but it's only got traction at the moment in the Gtk and related milieux.