search

OpenframeProject / Openframe

Openframe Frame Controller (alpha)
GNU General Public License v3.0
314 stars 18 forks source link

Some artworks crash Openframe during download #76

Closed jvolker closed 4 years ago

jvolker commented 4 years ago

I was testing using latest Raspian Buster on a Pi 3B and installed Openframe from the current master branch using a modified install script:
bash -c "$(curl https://gist.githubusercontent.com/jvolker/7be85a005b98fbd40b793d13b7250a44/raw/)"

Started Openframe with debugging on: DEBUG=* openframe

Two artwork examples that cause similar errors during download. Obviously the artwork configurations are faulty. Those artworks can't be downloaded. Looks like we need to catch this.

https://openframe.io/artwork/5d234ab4a38167076035bc65

  openframe:downloader downloading https://youtu.be/njSSoyCUEpE +2ms
/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/pretty-bytes/index.js:46
        throw new TypeError(`Expected a finite number, got ${typeof number}: ${number}`);
        ^

TypeError: Expected a finite number, got object: null
    at module.exports (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/pretty-bytes/index.js:46:9)
    at Request.<anonymous> (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/src/downloader.js:75:85)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)
    at reportState (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/request-progress/index.js:83:21)
    at call (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/throttleit/index.js:28:16)
    at Object.throttled [as reportState] (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/throttleit/index.js:20:26)
    at onData (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/request-progress/index.js:44:36)
    at emitOne (events.js:101:20)
    at IncomingMessage.emit (events.js:188:7)

https://openframe.io/artwork/5e4701aba38167076035c034

 openframe:downloader downloading https://opensea.io/assets/0x8ed70b10e67a207f8caa4433b83b962550ba81ee/23 +2ms
  openframe:pubsub pubsub client connected +650ms
/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/pretty-bytes/index.js:46
        throw new TypeError(`Expected a finite number, got ${typeof number}: ${number}`);
        ^

TypeError: Expected a finite number, got object: null
    at module.exports (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/pretty-bytes/index.js:46:9)
    at Request.<anonymous> (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/src/downloader.js:75:85)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)
    at reportState (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/request-progress/index.js:83:21)
    at call (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/throttleit/index.js:28:16)
    at Object.throttled [as reportState] (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/throttleit/index.js:20:26)
    at onData (/home/pi/.nvm/versions/node/v6.9.5/lib/node_modules/openframe/node_modules/request-progress/index.js:44:36)
    at emitOne (events.js:101:20)
    at IncomingMessage.emit (events.js:188:7)