search

OpeningDesign / OD_Library

This library has moved to: https://gitlab.com/openingdesign/OD_Library
34 stars 6 forks source link

adjustment of tag location #2

Open theoryshaw opened 5 years ago

theoryshaw commented 5 years ago

Hi @dimven

Thanks for pushing that script--a great start.

here's a video of running the script: https://www.dropbox.com/s/977i9v4li8m30hi/2019-01-16_15-25-40.mp4?dl=0

Is it possible to get the tags to not overlap on each other? 2019-01-16_15-25-59_sharexsharex_-_screen_recordingsharex


possible to move them over a little to the left, so they fit in that rectangle?


2019-01-16_15-32-40_i_view642019-01-16_15-28-11 png_-_irfanview_ zoom_1694_x_i_view64

test file and tag family... https://github.com/OpeningDesign/OD_Library/commit/0da46e68d14822477e0db82d4bc33bc44ae2abdc

dimven commented 5 years ago

Hi,

Did you run the graph twice consecutively as per the description? Remember the first run places the tags and fixes the API bug (automatically nudges the tags up and down so that they're not just showing a question mark). Only then can we get the correct extents of the tags and continue with part 2 - making sure they don't overlap

vkodipfcnc

Is the box that you're referring to part of the titleblock family?

theoryshaw commented 5 years ago

hi.. well look at that, no I did not do that! Will try. :)

I just meant moving the placed tags over to the left a little more to fit in the box illustrated below... image

image

see sheet layout in this file... https://github.com/OpeningDesign/OD_Library/blob/0da46e68d14822477e0db82d4bc33bc44ae2abdc/BIM/Dynamo%20Scripts/Material%20Tagging/test.rte

theoryshaw commented 5 years ago

Hi Dimitar, i think i found it... https://github.com/OpeningDesign/OD_Library/commit/6cf0c5d57231582349dbd3b82b3d347ef22b9874#diff-867ba39a557cdb958a7df3c33a62b3faR129

Is that correct?

dimven commented 5 years ago

That is totally it. We align the outside extent of the tag with the edge of the crop. I put a bit of a buffer of 0.5 ft. because it seemed to work well and look nice with the common cases. If you'd like we could externalize it as an input.