search

OpenlyOne / openly-rails

"GitHub" for Google Drive [inactive]
https://www.open.ly/
GNU General Public License v3.0
21 stars 1 forks source link

Contribution: Track accepted revision #331

Closed FinnWoelm closed 5 years ago

FinnWoelm commented 5 years ago

Add a column accepted_revision_id to keep track of the revision created for accepting the contribution. For now the column is used to display an accurate list of accepted changes in the review tab for accepted contributions. This column also replaces the now redundant is_accepted column.

Resolves #284 Fixes #283

codecov-io commented 5 years ago

Codecov Report

Merging #331 into development will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #331      +/-   ##
===============================================
+ Coverage        99.68%   99.68%   +<.01%     
===============================================
  Files              129      129              
  Lines             2885     2896      +11     
===============================================
+ Hits              2876     2887      +11     
  Misses               9        9
Impacted Files Coverage Δ
app/models/contribution.rb 100% <100%> (ø) :arrow_up:
...ontrollers/contributions/acceptances_controller.rb 100% <100%> (ø) :arrow_up:
...pp/controllers/contributions/reviews_controller.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2da2e26...c439b0d. Read the comment docs.