search

Openmesh-Network / xnode-admin

Administrator service to reconfigure and administrate a live xnode system.
MIT License
3 stars 2 forks source link

Feature/hmac #3

Closed harrys522 closed 4 months ago

harrys522 commented 4 months ago

Added the hmac security improvement for Xnode admin service

j-openmesh commented 4 months ago

Thanks Harry, This is going to take me a bit of time to review. I'll start reviewing it and get back to you on both this and Openmesh-Network/dpl-backend#5 (likely Saturday).

harrys522 commented 4 months ago

My PR was merged by dowdt https://github.com/Openmesh-Network/dpl-backend/pull/5 so Xnode admin will now be broken until we merge this PR and update XnodeOS to accomodate.

j-openmesh commented 4 months ago

@harrys522 Understood. These things happen. Normally I'd recommend reverting the dpl-backend change. However, given the context, let's review this PR today and address any issues with it and make a new PR on dpl-backend if needed. Then we can roll forward.