Openscapes / kyber

💎 Elegant tools for a more civilized age.
https://openscapes.github.io/kyber/
Other
17 stars 4 forks source link

improvements to listing GH teams/members #108

Closed ateucher closed 5 months ago

ateucher commented 5 months ago

In the first version of list_team_members() it only returned the first 30 members. This is because there is a 30 record limit in the GH API, beyond which you need to paginate. Setting .limit = Inf enables automatic pagination to get all records. This seems safe enough here as we're not ever going to get too many members for it to be a problem.

This PR also makes specifying org and team names in list_team_members() case insensitive, which will make it less prone to error unnecessarily. The API is not case sensitive.

Finally, this PR adds the ability to get pending invitations via the new members argument in list_team_members() (e.g., list_team_members(team = "longtermaccess2i2c", org = "nasa-openscapes", members = "invitations").

seankross commented 5 months ago

LGTM