Openscapes / kyber

💎 Elegant tools for a more civilized age.
https://openscapes.github.io/kyber/
Other
17 stars 4 forks source link

Check duration, addressing #66 #114

Open seankross opened 2 months ago

seankross commented 2 months ago

@stefaniebutland I'll work on this more this week, just wanted to give you a heads up this is in flight.

seankross commented 2 months ago

Hey @stefaniebutland, let me know what you think of this:

# grab this version of kyber
pak::pak("openscapes/kyber@check-duration")

library(kyber)

registry_url <- "[the registry url]"
cohort_id <- "2024-noaa-a"

check_duration(registry_url = registry_url, 
               cohort_id = cohort_id, 
               call_number = 1)

check_duration(registry_url = registry_url, 
               cohort_id = cohort_id, 
               call_number = 2)
stefaniebutland commented 1 month ago

Hi @seankross. Running this check confirmed that Call 2 durations, as expected, don't match. I think the issue is that kyber's calculated duration isn't accurate for Call 2; we won't necessarily use the check_duration function. Please see Julie's comment in the issue

registry_url <- "[the registry url]"
cohort_id <- "2024-nmfs-champions-a"
check_duration(registry_url = registry_url, 
                cohort_id = cohort_id, 
                call_number = 2)

output

ℹ Specified total duration: 90 minutes
ℹ Calculated total duration: 91 minutes