search

Opentek-Org / bookquotes

Generate lines, author, and book names from people's favorite books and also inspirational quotes!
https://www.npmjs.com/package/bookquotes
MIT License
19 stars 39 forks source link

Add tests and GitHub Actions #11

Closed gitaalekhyapaul closed 3 years ago

gitaalekhyapaul commented 3 years ago

Description

Fixes #10 Fixes #2

AnirudhPanda commented 3 years ago

I have changed the function name yesterday! Can you check that once and propose changes accordingly

gitaalekhyapaul commented 3 years ago

@AnirudhPanda fixed the issue in https://github.com/Opentek-Org/bookquotes/pull/11/commits/bc3f715f7d9fdc70ebeb4b439a76816268bbe796

AnirudhPanda commented 3 years ago

Hey @gitaalekhyapaul we have a new function to be added with this #13 PR

You can check that PR too and can suggest anything.

I will see to this PR

AnirudhPanda commented 3 years ago

Can you please describe what the gh action does?

gitaalekhyapaul commented 3 years ago

Hey @AnirudhPanda , it seems that #13 follows the older method of testing. I would suggest merging this PR and then telling that contributor to re-base

gitaalekhyapaul commented 3 years ago

Can you please describe what the gh action does?

The GH action installs dependencies and then runs the unit tests. I am using Jest to run the unit tests.

saif-malik-01 commented 3 years ago

Hey @gitaalekhyapaul ! Basically the main motive of PR #13 is to implement a new functionality in the functions and update the readme accordingly. You can check and re implement the test according to the new code base.

gitaalekhyapaul commented 3 years ago

I have gone through the code @saif-malik-01 , but it follows an older method of testing, which cannot be automated through GH actions. The step to solving this issue is to merge this PR and then you can re-base to incorporate the new test framework in your code.

saif-malik-01 commented 3 years ago

@gitaalekhyapaul you are right, is it ok if I don't implement any test and only make a PR with functionality changes.

gitaalekhyapaul commented 3 years ago

@saif-malik-01 why not wait for this PR to get merged? You can just refactor your code after that.

gitaalekhyapaul commented 3 years ago

Hey @AnirudhPanda , I guess we are ready to merge this PR, let me know if you have any other queries :+1:

AnirudhPanda commented 3 years ago

Great @gitaalekhyapaul and @saif-malik-01

Merging this PR but I want someone to update the Readme to what changes we have did with the package! Will you do it @gitaalekhyapaul

I will publish the new patch in 1-2 days

gitaalekhyapaul commented 3 years ago

Yeah sure, @AnirudhPanda ... anyways I have to work on the greetings workflow after this. I'll help you out for sure!

AnirudhPanda commented 3 years ago

Yeah sure, @AnirudhPanda ... anyways I have to work on the greetings workflow after this. I'll help you out for sure!

Thanks man! Appreciate it