search

Opentek-Org / bookquotes

Generate lines, author, and book names from people's favorite books and also inspirational quotes!
https://www.npmjs.com/package/bookquotes
MIT License
19 stars 39 forks source link

Added new Quotes #32

Closed DADDY-DOUBLESHOT closed 3 years ago

ghost commented 3 years ago

Hey there! :wave: This repository uses the Prettier code style.

You forgot to format these files in your pull request:

The Prettier installation guide is a good place to get started with formatting your code properly. Thanks!

:heart:

Your friendly Prettifier bot.

DADDY-DOUBLESHOT commented 3 years ago

Added new quote @AnirudhPanda

DADDY-DOUBLESHOT commented 3 years ago

I have modified the Hashmap now we can search in O(1) to find the sent Quotes @AnirudhPanda

AnirudhPanda commented 3 years ago

Hey @DADDY-DOUBLESHOT A quick suggestion

Create an issue for the same (using hashmap thing) and then create a PR only to solve that issue! This will be helpful for us too and it is a good practice to do one thing at a time

DADDY-DOUBLESHOT commented 3 years ago

Thank you @AnirudhPanda for mentioning those details about my PR . I will create those issue and perform those tasks ASAP , PS this is my first PR thanks for your humble guidance :)