Inspire quotes functionality and test added - #3

Opentek-Org / bookquotes

Generate lines, author, and book names from people's favorite books and also inspirational quotes!

https://www.npmjs.com/package/bookquotes

MIT License

19 stars 39 forks source link

Closed saif-malik-01 closed 3 years ago

saif-malik-01 commented 3 years ago

Implemented the functionality in getLines and getRandomLines to get specific type quotes #3.
Test added for those functionality.
Add type abbreviation in readme.

ghost commented 3 years ago

Hey there! :wave: This repository uses the Prettier code style.

You forgot to format these files in your pull request:

The Prettier installation guide is a good place to get started with formatting your code properly. Thanks!

:heart:

Your friendly Prettifier bot.

AnirudhPanda commented 3 years ago

Is everything good here? @saif-malik-01

@gitaalekhyapaul do you have anything to say about these changes?

saif-malik-01 commented 3 years ago

From my perception everything is ok.

AnirudhPanda commented 3 years ago

Great @saif-malik-01

would you like to review #31

gitaalekhyapaul commented 3 years ago

@AnirudhPanda can you run this PR locally? It seems that the tests aren't running locally

gitaalekhyapaul commented 3 years ago

Also, @saif-malik-01 did you re-base after PR #11 got merged? I can see my code changes in your git blame.

The git blame seems very messy, you should re-base your branch with the upstream, and then add your code.

saif-malik-01 commented 3 years ago

@gitaalekhyapaul I checked on my system all test are passed.

gitaalekhyapaul commented 3 years ago

@gitaalekhyapaul I checked on my system all test are passed.

This might be because you did not re-base with upstream?

saif-malik-01 commented 3 years ago

@gitaalekhyapaul ops! I forgot that , thanks.