Opentek-Org / bookquotes

Generate lines, author, and book names from people's favorite books and also inspirational quotes!
https://www.npmjs.com/package/bookquotes
MIT License
19 stars 39 forks source link

New Hashmap functionality added #42

Closed DADDY-DOUBLESHOT closed 2 years ago

DADDY-DOUBLESHOT commented 3 years ago

Hey @AnirudhPanda I have created new Hashmap issue and also PR please have a look .

ghost commented 3 years ago

Hey there! :wave: This repository uses the Prettier code style.

You forgot to format these files in your pull request:

The Prettier installation guide is a good place to get started with formatting your code properly. Thanks!

:heart:

Your friendly Prettifier bot.

DADDY-DOUBLESHOT commented 3 years ago

hey @AnirudhPanda I have added those descriptions you asked for hope this time my PR gets merged , thank you

AnirudhPanda commented 3 years ago

Hey, @gitaalekhyapaul would you mind testing this? Shall I merge it to v1.1.0 and then you'll test?

I guess this is done only for the array and not for the isnpireArray ?

gitaalekhyapaul commented 3 years ago

@AnirudhPanda you can go ahead and merge the new functionalities if you like, I'll add tests for them in #36

AnirudhPanda commented 3 years ago

Hey, @gitaalekhyapaul would you mind testing this? Shall I merge it to v1.1.0 and then you'll test?

I guess this is done only for the array and not for the isnpireArray ?

@DADDY-DOUBLESHOT

DADDY-DOUBLESHOT commented 3 years ago

I guess for that we need to then add hashmap for every type of quote like for inspire and cheerful etc ... @AnirudhPanda

AnirudhPanda commented 3 years ago

I guess for that we need to then add hashmap for every type of quote like for inspire and cheerful etc ... @AnirudhPanda

Currently we have the inspire array as an extra

DADDY-DOUBLESHOT commented 3 years ago

Hey @AnirudhPanda I made those changes you requested in readme file but unable to push on v1.2.0 Can you guide me here a little bit about on which branch shall I push those changes and how... thank you