Opentrons / opentrons

Software for writing protocols and running them on the Opentrons Flex and Opentrons OT-2
https://opentrons.com
Apache License 2.0
416 stars 177 forks source link

PD: Modal overflow #6832

Open howisthisnamenottakenyet opened 3 years ago

howisthisnamenottakenyet commented 3 years ago

Background

As a user I want to be able to tell how to close a non-scrollable modal.

There is an issue with one of PD's modals when the browser height is too short- content spills off of the bottom of the modal (please note the '[ ] don't show me again' and 'ok' button on the grey overlay). There is room at the bottom of the screen for the modal to expand and accommodate this content.

How do we best address this?

image.png

mcous commented 3 years ago

Coincidentally, we just hit a similar issue in the App involving scrolling release notes in a modal. We now have a <BaseModal> React component available designed to better accommodate scroll behaviors which may be helpful here