search

Openvario / meta-openvario

Official OpenEmbedded layer for Openvario flight computer.
http://www.openvario.org
30 stars 29 forks source link

Maps Checksums invalid during build #139

Closed lordfolken closed 2 years ago

lordfolken commented 2 years ago

https://github.com/Openvario/meta-openvario/blob/57ccb1bf533e275be7cd561254633a93316639c4/recipes-apps/xcsoar/xcsoar-maps-alps_0.1.bb#L20 The maps get now updated regularly. So hardcoding the checksums here will fail. Can you source a checksum's file ? I could create one.

linuxianer99 commented 2 years ago

Hey. Yes, it should be possible to specify a checksum URI link

Would be great, if you generate these files for us !!

linuxianer99 commented 2 years ago

@lordfolken : Any progress on this ?? Would be a good chance to have this in the new hardknott layer ;-)

lordfolken commented 2 years ago

Waiting for https://github.com/XCSoar/xcsoar-data-maps/commit/da2344b46fe005a04867dcca77a96314860c43f3 to complete. Then we will have .sha256 files in http://download.xcsoar.org/maps/

lordfolken commented 2 years ago

@linuxianer99 ok the checksums are now online in http://download.xcsoar.org/maps/ for example: http://download.xcsoar.org/maps/ALPS_HighRes.xcm.sha256

There are some outdated airspace and flarmnet files in the bitbake files. I'm not sure what to do about those, and i have no influence on them.

August2111 commented 2 years ago

From my point of view we should remove all recipes xcsoar/xcsoar-maps-*.bb: As lordfolken mentioned there are some very old and outdated data in (f.e. in maps-alps the airspace file from Austria 2011!) We should use only one xcsoar-data.bb recipe with all data files for a clean XCSoarData directory with the default map file, default profile and such data files... (f.e. lua examples!) I think the better solution is to make it easy to download this current files from internet... If you are agree with this I will prepare a PR with my proposal...

Of course we can switch off the hashsum check (f.e. with BB_HASHBASE_WHITELIST...) or we make a lot of affort to synchronize the checksums - but all this staff is never needed I think!

Nevertheless it is very fine to have the .sha256 files on the maps download folder, to check it in XCSoar after the download...

lordfolken commented 2 years ago

I think its a good thing that there is a map in the image. I have a kind of a plan to do this for other XCSoar platforms as well. Would prevent the white screen currently greeting new users. So by all means keep a few maps in there.

Airspace etc is all highly variable data. There it makes less sense to supply with the image. The question is: what is the process for the (offline) end user to get this data?

August2111 commented 2 years ago

I think its a good thing that there is a map in the image. I have a kind of a plan to do this for other XCSoar platforms as well. Would prevent the white screen currently greeting new users. So by all means keep a few maps in there.

I totally agree with you - and for this OpenVario has a openvario_default.xcm in the data path - and loaded with the profile :) This is showing on start at a really fresh image. Most of the guys know, where to get the correct map - either with a filled USB stick or with an internet connection (wired or wifi). And this default-map is a must for the delivery package! But I want to skip the affort for all other data files ...

In my club in the next year I want to update all OV devices with an WLAN stick - and we have a functional WLAN on our whole airfield, so it is easy to download everything itself. Besides, one can upload IGC files and download task and all this things - this will be the future. So we don't need so much installation data, only some small ones, that everyone can easy see how it works! For the offline guys the USB memory stick is still available and described...

linuxianer99 commented 2 years ago

The idea behind all this maps packages was a long time ago .... We wanted to update the complete flight computer using a package based approach ... So also the maps ... But i think this was not used often, so i agree to just deliver a base map with the image ...

On the other hand, we can use the github actions to automatically build the new maps as ipks. So installation via "standard" opkg and usb stick is possible for the "offline" flight computers ??

August2111 commented 2 years ago

I don't know... In the beginning of OpenVario this was a very good idea - but now? I prefere the handling of maps and other data inside the XCSoar software completely - not the indirection/detour with the OV menu...

linuxianer99 commented 2 years ago

ok. Also fine for me :-)

Think also, we should think about the packet based update method ... Maybe we do this just for selected packages like XCSoar, but not for the whole OS. I will create a seperate ticket for this discussion ...

@August2111 @lordfolken : So we close this ticket and continue the update concept in #148

August2111 commented 2 years ago

This sounds good :) BTW we live in a 3-country corner - and this makes it diffecult to use such a predefined map... We create a user defined own one, what also can be build very easy...