search

Openvario / meta-openvario

Official OpenEmbedded layer for Openvario flight computer.
http://www.openvario.org
29 stars 29 forks source link

moving logbook script to the right place #340

Closed Blaubart closed 1 year ago

Blaubart commented 1 year ago

The logbook script is part of the x-menu and not of ovmenu-ng.

So it has to be placed at /meta-ov/recipes-apps/xcsoar/files instead of /meta-ov/recipes-apps/ovmenu-ng-skripts/files.

MaxKellermann commented 1 year ago

This script is just as useless as this sysinfo script. It should never be used by x-menu.

Blaubart commented 1 year ago

why do you think this script is useless?? The logbook is almost the same like the Kobo image uses it.

MaxKellermann commented 1 year ago

Unlike the Kobo version, it outputs an ASCII text which works only with a fixed-width font, which obviously looks ugly. It is an obscure shell script that does very fragile things. And it attempts to replicate code for which a better version already exists in the XCSoar repository. The script is bad and redundant.

linuxianer99 commented 1 year ago

How should we handle to ovmenu-ng vs. x-menu ?

I would suggest putting all effort to x-menu ...

Scumi commented 1 year ago

How should we handle to ovmenu-ng vs. x-menu ?

I would suggest putting all effort to x-menu ...

Logbook functionality has been added by Max to the x-menu (bedf78b).

There are currently two PRs open (XCSoar/XCSoar#1107 and XCSoar/XCSoar#1214) trying to get the x-menu in a usable state. I fully agree on your suggestion.

Blaubart commented 1 year ago

I fully agree, too. I think we can close this PR?