search

OpenwaterHealth / OpenLIFU-python

focused ultrasound toolbox
GNU Affero General Public License v3.0
8 stars 2 forks source link

Make k-wave-python a direct dependency #78

Closed ebrahimebrahim closed 2 months ago

ebrahimebrahim commented 2 months ago

Closes #7

It was previously indirect becasue of a windows issue in the main codebase that had yet to be released.

The new release is said to support MacOS so we open that up for testing in the CI.

ebrahimebrahim commented 2 months ago

Could we configure the project so that it runs an import kwave as part of the installation process, which will trigger the download of the binaries if they aren't found on the system? That way the dependency gets fully installed.

something like: python -c "import logging; logging.basicConfig(level=logging.INFO); import kwave"

Great idea. As I look into it, it seems not as straightforward as I thought. Let me keep digging for a bit

ebrahimebrahim commented 2 months ago

Will continue looking into this, but if we decide that it should be an issue on k-wave-python then we can also open that issue and merge this PR. Let me know

peterhollender commented 2 months ago

I think we open the issue on k-wave-python for more verbose communication during first time download, and solve this during custom app deployment for ours. We can resolve this issue.