Closed ebrahimebrahim closed 2 months ago
Instead of passing, it would be better for unimplemented methods to raise a NotImplementedError so that it is clear when using a Database what is or isn't intended to work
NotImplementedError
Database
Example: https://github.com/OpenwaterHealth/OpenLIFU-python/blob/0efbc2c907b00e9eb2b7265204a9373d5aefaeef/src/openlifu/db/database.py#L201-L203
Instead of passing, it would be better for unimplemented methods to raise a
NotImplementedError
so that it is clear when using aDatabase
what is or isn't intended to workExample: https://github.com/OpenwaterHealth/OpenLIFU-python/blob/0efbc2c907b00e9eb2b7265204a9373d5aefaeef/src/openlifu/db/database.py#L201-L203