Unimplemented methods in `database.py` should raise an exception

OpenwaterHealth / OpenLIFU-python

focused ultrasound toolbox

GNU Affero General Public License v3.0

10 stars 2 forks source link

Unimplemented methods in `database.py` should raise an exception #79

Closed ebrahimebrahim closed 2 months ago

ebrahimebrahim commented 3 months ago

Instead of passing, it would be better for unimplemented methods to raise a NotImplementedError so that it is clear when using a Database what is or isn't intended to work

Example: https://github.com/OpenwaterHealth/OpenLIFU-python/blob/0efbc2c907b00e9eb2b7265204a9373d5aefaeef/src/openlifu/db/database.py#L201-L203