Undefined items in `database.py`

[ebrahimebrahim]

There is a number of undefined items in src/openlifu/db/database.py, as though perhaps there is a missing dependency

for example Volume, UltrasoundSystem, Standoff, generate_standoff_mask, Session

(In the case of Session it looks like it's just a missing import)

Are many of these things slated to be implemented but not implemented yet? If so then similarly to #79 we should raise an exception indicating that

[peterhollender]

Correct, they aren’t implemented yet. Did a bulk conversion of the Matlab to Python, and hadn’t implemented to those classes yet. Agreed they should raise exceptions in the meantime.

On Wed, Jul 10, 2024 at 10:50 AM Ebrahim Ebrahim @.***> wrote:

There is a number of undefined items in src/openlifu/db/database.py, as though perhaps there is a missing dependency

for example Volume, UltrasoundSystem, Standoff, generate_standoff_mask, Session

(In the case of Session it looks like it's just a missing import)

Are many of these things slated to be implemented but not implemented yet? If so then similarly to #79 https://github.com/OpenwaterHealth/OpenLIFU-python/issues/79 we should raise an exception indicating that

— Reply to this email directly, view it on GitHub https://github.com/OpenwaterHealth/OpenLIFU-python/issues/80, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPN2LMRFRHXR3XXPZXYX4LZLVC2LAVCNFSM6AAAAABKVCTAK2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYDAOJZGAYDMNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[ebrahimebrahim]

In that case this is a duplicate of #79, so closing it. It is to be resolved in #79