search

Openworx / backend_theme

Odoo Backend Theme
156 stars 242 forks source link

Submit your changes to web_responsive #21

Closed lasley closed 6 years ago

lasley commented 6 years ago

Hi - Happy to see you're getting good use from web_reponsive!

I noticed that you've made some changes that would be most welcome in the base module. Do you have any thoughts to submitting these upstream?

rafaelbn commented 6 years ago

Hi @mgielissen , is this an option for you? We could try to help you

lasley commented 6 years ago

Yeah I'm actually quite curious why the code was included here instead of just depending on the web_responsive module? I specifically designed things to be quite modular, with theming use case at the forefront of thought.

mgielissen commented 6 years ago

There where a lot of changes (and way faster to implement), that's the reason the code was included instead of depending on the module. Maybe the code can depend on the module, but that will take some time to investigate. So any help is welcome.

lasley commented 6 years ago

I'm not willing to put forth effort to a project that hides authorship (#22). Sorry

mgielissen commented 6 years ago

The theme now depends on web_responsive. https://github.com/Openworx/backend_theme/commit/6b2f2ba31b9a82aec31910d998299c90218c4691

lasley commented 6 years ago

Nice, thank you @mgielissen. It makes me happy to see that we came to a good solution here and that it didn't cost you too much dev effort.

I'll be letting the customer that noticed the module incompatibility know that they can now safely use your theme in combination with web_responsive.

rafaelbn commented 6 years ago

Thank you @mgielissen ! 😄