Authorship Removed

[lasley]

I noticed that authorship of LasLabs, Tecnativa, and Odoo Community Association (OCA) have been removed from this module.

While it's not strictly required with the licensing, you are not the sole author of this module & it is definitely spitting in the face of the other authors by removing it.

[rafaelbn]

Hi @mgielissen , It would be more beneficial for the entire community to continue contributing to OCA and joining efforts

[yajo]

I think we could instead pull those changes back into the original web_responsive and drop their authorship, so they feel it too 😆

[lasley]

Therein lies the beauty of open source, and I am obviously not above doing something like that. I would prefer that we collaborate though - it's more beneficial to the users of our products IMO

[mgielissen]

Authorship is retained in the source and also mentioned in the Module description.

[mgielissen]

Anyway, the module is truly open source and not like Unibravo or RStudio, they rip and sell Odoo's web_enterprise module.

[lasley]

@mgielissen So your standpoint is that you don't care and that someone does it worse, so it's OK?

I'm fine with people taking credit for my work, I just like to understand where exactly someone stands on things for future reference.

[mgielissen]

Your authorship is still there in the source code and credits to you in the description and license is the same. What would you see more?

Example:

-- coding: utf-8 --

Copyright 2016 Openworx, LasLabs Inc.

License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).

[lasley]

You specifically removed authorship from the author key in the manifest, while more than half the code here was created by me and not you. I donated this code to OCA, and Tecnativa subsequently made improvements. None of that is indicated here, and again you're the sole author to the customer perspective instead of the four that actually exist (LasLabs, Tecnativa, Openworx, OCA).

As mentioned, I understand what you did isn't illegal - the author key in the manifest is not covered by licensing in any way. Open source is open source, and you're technically fostering that by creating a derivative. We'll be fostering the same thing by pulling code changes back into our module as @yajo suggested in https://github.com/Openworx/backend_theme/issues/22#issuecomment-331798583.

That said- any time I pull a module from a repo and create a derivative, the original author key stays in-tact and I become a co-author. It's a matter of respect versus strict legality. A great example is @yajo's comment in https://github.com/Openworx/backend_theme/issues/22#issuecomment-331798583 - this puts us at odds with each other instead of us simply working together to create good software.

You even said yourself in #21 that you included the code here simply because it was easier than figuring out how to extend it. Had you taken the further step to extend the module properly, I wouldn't be here claiming you removed authorship. Instead, my work made it easier for your work.

An example is the fact that I just spent 30 minutes explaining to a customer why they cannot install your addon and mine at the same time. I had to point them deep into descriptions so they would understand what exactly the problem is. I also had to point them to significant improvements we've made in our module that your's doesn't contain because the copy is outdated.

This issue was primarily about explaining our viewpoint. It's obvious you aren't trying to do wrong (like the others you mentioned previously that do in fact rip modules off), so I was just explaining the common custom of taking co-authorship when creating derivatives instead of full authorship. You see the same thing in other industries - such as books, where there could be five or six authors a few revisions down the line.

[mgielissen]

Ok, in a short way it's best to depend on web_responsive instead of adding code right into the code?

Or add as author: 'Openworx, LasLabs, Tecnativa, and Odoo Community Association (OCA)'?

[lasley]

Exactly - Either one would make us happy! From a customer perspective, the first would be the ideal because then our modules can live in harmony. Right now it's an either/or situation, which isn't that awesome IMO.

Honestly I like what you did here and I'd be happy to help work towards breaking the modules apart. Our goal with web_responsive was modularity, and I designed specifically to allow drastic changes such as what happen in this module. Worst case scenario, I can make some modifications there so we can do what we need here.

[mgielissen]

I will check this weekend if I can split the module and make web_responsive a depency.

[mgielissen]

It's possible to split the module. I have a proof of concept which basically puts an background image on the app dashboard with 100% screenwidth and removes transition.

[lasley]

Hooray - that was easy indeed!

[mgielissen]

The new version is almost finished and now depends on web_responsive.

[mgielissen]

See https://github.com/Openworx/backend_theme/commit/6b2f2ba31b9a82aec31910d998299c90218c4691

[lasley]

Thank you for your swift attention @mgielissen!

[rafaelbn]

Thank you @mgielissen ! 👍