search

OperationCode / front-end

Operation Code's website
https://operationcode.org
MIT License
371 stars 269 forks source link

Limit width of page content to match width of nav bar #1610

Closed toadkicker closed 1 year ago

toadkicker commented 2 years ago

For example, there is text well into the gutters of the branding page, and those gutters are not equal sizes.

Screen Shot 2022-05-31 at 10 41 36 AM
kylemh commented 2 years ago

This is expected. The nav isn't meant to flag the existence of a gutter. I'm not a designer. I just implemented mocks I received.

datphotogurl commented 2 years ago

@kylemh does this help to re-open the issue? Branding-Page-MockUp

kylemh commented 2 years ago

No, I'm not sure what's being said. There exist dozens of pages where the nav width isn't the guide for gutters. Content spans past that width on many instances.

toadkicker commented 2 years ago

I think that is a bug not a requirement

kylemh commented 2 years ago

What I'm saying is this specific UI spans past the nav, but it also does on many pages because it's not related.

That doesn't mean we can't fix the UI. It also doesn't mean we can't fix only THIS UI.

I only had context that you were reporting these issues as a helpful bypasser. If @datphotogurl wants this UI changed in some way, I'll do so!

datphotogurl commented 2 years ago

I believe Todd was just making helpful suggestions. If the CSS width spans on all of the pages, could we fix that for all the pages?

kylemh commented 2 years ago

Not simply, but it's certainly something we can explore.

kylemh commented 2 years ago

edited title and OP and reopened issue

aashmanVerma commented 1 year ago

is this issue still available to work on ?

kylemh commented 1 year ago

Yes, but I don't think it will be a simple issue - just a heads up!

recondesigns commented 1 year ago

Yes, but I don't think it will be a simple issue - just a heads up!

I see that the nav has a max-width of 1200px, but not seeing any other sections of content (or content) with that constraint. Are you thinking there would need to be changes for each page, or possibly even each section of content?

kylemh commented 1 year ago

The Container component (which is omnipresent) has a max-width of 1400px.

The difficulty in this ticket is that there are MANY components that have arbitrarily set max-widths. The solution won't be just changing Container and/or Nav.