search

OperationCode / front-end

Operation Code's website
https://operationcode.org
MIT License
366 stars 270 forks source link

Replace all styling with Tailwind #1725

Open kylemh opened 9 months ago

kylemh commented 9 months ago

Blocked by #1724

kylemh commented 9 months ago

@subhajit20 You could gradually work on this one! One component and/or one page per PR. It's nice because you won't feel like there's a mountain of work. Just whatever you feel comfortable contributing.

subhajit20 commented 9 months ago

@kylemh Sure, Can you assign this to me?

kylemh commented 9 months ago

Note that you may need to define Tailwind theme values to leverage the existing CSS values more ergonomically:

https://github.com/OperationCode/front-end/blob/main/common/styles/variables.css https://github.com/OperationCode/front-end/blob/main/common/styles/media-queries.css https://github.com/OperationCode/front-end/blob/main/common/styles/themeMap.js

subhajit20 commented 9 months ago

@kylemh when I push changes this error is comming Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

Will I change ReactDom.render to create room for all the test files?

kylemh commented 9 months ago

This is a Next.js application. ReactDOM.render is not used in this repository. Perhaps try re-installing dependencies? Hopefully you've gone through the README instructions!

subhajit20 commented 9 months ago

This is a Next.js application. ReactDOM.render is not used in this repository. Perhaps try re-installing dependencies? Hopefully you've gone through the README instructions!

Sorry I have fixed that

akash0708 commented 8 months ago

Hello @kylemh is the issue still open? I can help in converting the CSS of the footer to Tailwind. Since this is a big issue I hope it wouldn't be a problem with @subhajit20 if I join.

kylemh commented 8 months ago

I don't think it'd be a problem! Just steer clear of the work being done in #1746 obviously

akash0708 commented 8 months ago

Yes, I will make sure I do that. Should I start working on this? Can you assign me?

kylemh commented 8 months ago

I can only assign one person to an issue on GitHub. Feel free to work on it regardless. Maybe post here what components you are working on for visibility.

subhajit20 commented 7 months ago

hey @kylemh I am not able to make another pr, the create new pr popup is not coming on the pull request page .

kylemh commented 7 months ago

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request hopefully this helps!

subhajit20 commented 7 months ago

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request hopefully this helps!

done that,Thanks

kylemh commented 6 months ago

@subhajit20 please note the changes I made here: https://github.com/OperationCode/front-end/compare/main..ee6c78cfe6ef2bdb5a67a34857e0ccb7372ac9c7