search

OperationCode / front-end

Operation Code's website
https://operationcode.org
MIT License
371 stars 269 forks source link

Redesign Code School Card component #388

Closed kylemh closed 5 years ago

kylemh commented 5 years ago

Feature request

Is your feature request related to a problem? Please describe.

The code school card component has received new mocks after more discussion. It's an important aspect of the most visited page on our site.

Describe the solution you'd like**

1) The locations field.

Notes:

szempled commented 5 years ago

Hey I'm new and still working on my first PR. I have chosen this to my first issues. Any guidance would be appreciated. Thanks

kylemh commented 5 years ago

hi @szempled if you're familiar with React, JavaScript, HTML, and CSS, this issue should be no problem for you to tackle. Is there anything above that seems unclear?

The component(s) you'll be rewritting/editing are here.

kylemh commented 5 years ago

I am assigning myself to this issue as a placeholder for @BachAmadou . Thank you, and good luck! 😁

Please note: If no activity is shared within two days, I will remove my assignment. At that point, the issue will be open for anybody to take.

szempled commented 5 years ago

Hey Guys,

Sorry for the delay, just back from the weekend. I signed for as many trial lessons as I could for the tutorial for Git, is there anymore documentation about how to fork a branch and check out software. I really want to get rolling. Also to answer your question about the languages. I have some experience with javascript and I’m still very novice with HTML and CSS. I do however have alot experience with C++ OOD. I’m trying to fet into other aspects and see what is out there.

Dave

On Mon, Apr 8, 2019 at 4:52 AM Kyle Holmberg notifications@github.com wrote:

I am assigning myself to this issue as a placeholder for @BachAmadou https://github.com/BachAmadou . Thank you, and good luck! 😁

Please note: If no activity is shared within two days, I will remove my assignment. At that point, the issue will be open for anybody to take.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OperationCode/front-end/issues/388#issuecomment-480743773, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ8pI2tudUkfCEr3R-Un-P7zTfJ6m2ePks5vewM5gaJpZM4cXOEy .

kylemh commented 5 years ago

@szempled I don't want to deter you from contributing. I love the drive. I'd say that accomplishing this issue in the timeframe we're seeking would be very difficult - I don't want you to have a negative OSS experience. I recommend instead focusing on going the the front-end web cert on freecodecamp.org and then maybe going through a React course on Egghead or Udemy! If you're dead-set on trying to grind through an issue, you can register on our site -> https://operationcode.org/join and then ask for a Slack invite within 24 hours. I'm @kylemh on there as well, and we can schedule some 1-on-1 time.

szempled commented 5 years ago

Hey Kyle,

Oh ok no problem. I got confused because it had a "good first issue" I didn't think it had such a tight deadline. I went through a lot of the front end web cert stuff a year ago to get a feel for web design, reading through https://reactjs.org/tutorial/tutorial.html now doesn't seem to be crazy. My background is mainly embedded systems; however, I do want to branch out from a professional perspective. Would you mind letting me know what I could get involved with where there is a low a priority and a team lead in your immediate network that could use somebody? Possibly a project that's well documented, if not that cool I don't mind taking the time reading line by line. Still trying to get a lay of the land, but if its documented I'll read it.

Dave

On Mon, Apr 8, 2019 at 6:42 PM Kyle Holmberg notifications@github.com wrote:

@szempled https://github.com/szempled I don't want to deter you from contributing. I love the drive. I'd say that accomplishing this issue in the timeframe we're seeking would be very difficult - I don't want you to have a negative OSS experience. I recommend instead focusing on going the the front-end web cert on freecodecamp.org and then maybe going through a React course on Egghead or Udemy!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OperationCode/front-end/issues/388#issuecomment-481034725, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ8pI3CpmFvWlKlGQh224snJt5i3oROjks5ve8XogaJpZM4cXOEy .

kylemh commented 5 years ago

Out of curiosity, is your understanding of good first issue:

szempled commented 5 years ago

Base assumption was good first issue was a little bit of all of the above.

On Tue, Apr 9, 2019 at 5:07 PM Kyle Holmberg notifications@github.com wrote:

Is your understanding of good first issue to be:

  • good first issue to acquaint yourself with this repository
  • good first issue to see how to contribute on GitHub
  • good first issue for new developers

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OperationCode/front-end/issues/388#issuecomment-481440589, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ8pI6rvhyWY0Ts0y80BgFhaMSCbMLfwks5vfQD-gaJpZM4cXOEy .

kylemh commented 5 years ago

I honestly have no idea - I tried googling... I guess for this repository (and I'll update the README to prevent further confusion), I'm hoping it helps people who are familiar with our tooling feel comfortable to dive in to the repo.

Essentially, I've been using "good first issue" as a way of communicating: "if you know some of our tools (JavaScript, HTML, CSS), this is a great issue to start contributing with us"

390 is a really solid one in my mind since Cypress' documentation is so good, I highlighted some hand-selected materials, and you don't need to be super familiar with React - just how to use DOM selectors and make helpful e2e assertions.

If you read all of those materials, plus CONTRIBUTING.md, I think you should be well under way. Let me know if you'd like me to assign it to you.

juliantrueflynn commented 5 years ago

Notes from call with Kyle discussing this ticket and feature changes and clarification:

  1. Locations (which are either "Multiple locations" or single location) will be in same in same row as "Campus Locations" like other sections in mock design.
  2. If "Multiple locations", then display button with the text "See full list" that opens modal. Button should be styled to look like a link (i.e. underline, maybe blue if that looks good).

Edit:

@kylemh how about putting modal in code_schools.js instead of having it in each SchoolCard? That would be more optimized, but there's not that many cards so not a big deal. Event handler in SchoolCard would pass ID to know which locations to show in modal.

kylemh commented 5 years ago

We spoke on the bottom topic on Slack 👍