OperationCode / front-end

Operation Code's website
https://operationcode.org
MIT License
371 stars 267 forks source link

Create pagination component #447

Closed kylemh closed 5 years ago

kylemh commented 5 years ago

Feature request

Is your feature request related to a problem? Please describe. We will eventually be creating a page for our resources API. In preparation, we can accomplish some work ahead of time before the API is ready to go.

Describe the solution you'd like Create a pagination component to navigate multiple pages of results.

Here is the mock: Screen Shot 2019-04-27 at 9 33 10 PM

Adjustment: Instead of coloring the active page blue, please wrap it in the same blue as a square border (for accessibility concerns).

Note: I highly recommend building the component using Storybook as a work-bench and keeping track of the following edge cases:

kylemh commented 5 years ago

Kevin asked to be unassigned so he can take a vacation before he starts his kick-ass new job!

I'm going to close his work-in-progress pull request, and open this issue back up to the public.

Feel free to reference his work if you'd like: https://github.com/OperationCode/front-end/pull/500/files

michaelGerstner commented 5 years ago

I can make this.

juliantrueflynn commented 5 years ago

Cool, go for it @michaelGerstner. I will assign myself to show this is taken.

juliantrueflynn commented 5 years ago

@michaelGerstner Just following up to see if you are having any issues I could maybe help with. Typically we like to give ~2 weeks, which is approaching, before changing assignment to someone else unless it's being worked on.

juliantrueflynn commented 5 years ago

@michaelGerstner Since I haven't heard back or seen any activity I'm going to take the assignment off myself and leave this open to anyone else to try. Let me know if you want to take another crack at it.

IAMOTZ commented 5 years ago

I would like to work on this issue. Just to clarify, all I need to do is create the Pagination component, I don't need to use it anywhere right?

kencollier3 commented 5 years ago

Ok so this also looks like it's gone stale. Want me to look at this too @kylemh ?

kylemh commented 5 years ago

@kencollier3 this one needs to get done ASAP - feel free to snag, but we're not reserving things anymore ❤️

kencollier3 commented 5 years ago

Fair enough.

brittanyjoiner15 commented 5 years ago

I would love to help with this! But I’m quite a newbie and only familiar with HTML/CSS at the moment.

So I am assuming a it’s kinda like a mini nav bar structure?

I’ll take a look at storybook!

kylemh commented 5 years ago

You know how you make a google search and page numbers show up below where each link goes to the next page? You’re just defining the UI for that.

If you’d like to setup some time, we could maybe meet next week to start off the work with paired programming. Just slack me.

brittanyjoiner15 commented 5 years ago

Yeah let's do that - i'll slack you.

chynh commented 5 years ago

@kylemh is this issue still up for grabs or is it already been taken care of?

kylemh commented 5 years ago

A PR for it exists, so I’d look elsewhere.