OperationCode / operationcode_backend

This is the backend repo for the Operation Code website
https://operationcode.org
MIT License
62 stars 110 forks source link

Update devise #496

Closed jaydorsey closed 5 years ago

jaydorsey commented 5 years ago

Description of changes

There's a devise bug that breaks in Ruby >= 2.5. This prevents the app from being upgraded to Ruby >= 2.5

Since Ruby 2.3 is EOL, I'm going to submit a separate PR where I upgrade to Ruby 2.6.3 (latest), but this PR being merged is a pre-requisite. Without this, you get an error per the issue noted below when trying to setup/test

Related:

This was a bundle update devise --conservative in an attempt to update the minimal amount of gems necessary. I specifically went with the latest, versus the minimal version that resolves the issue above just because I know there are a few other issues that were resolved by latest.

Issue Resolved

Supports #484 as a prerequisite to a Ruby 2.5+ upgrade (2.6.3 planned) per devise bug listed above