search

OperationCode / operationcode_bot

Slack bot for responding to Slack events and handling interactive messages. (not currently in use)
MIT License
8 stars 37 forks source link

rubocop #15

Closed raylu closed 7 years ago

raylu commented 7 years ago
  1. run rubocop in the default rake task so it runs as part of CI
  2. fix a bunch of stuff, including an interesting bug: 435088a

I'm not super happy about Style/TrailingCommaInLiteral but you can read my musings in f0496d4

I'm also not happy about Style/RedundantParentheses because not having parens on function calls causes all sorts of ambiguous parsing (some_func 1-2 vs some_func 1 -2) including in this very project, causing me to have to work around it (615ad09). That ship has long sailed, though

You can see what a faililng build looks like here: https://travis-ci.org/raylu/operationcode_bot/builds/199111596

rickr commented 7 years ago

Sounds good. Thanks for trying!