OperationCode / operationcode_frontend

Front-end repository for live site. Please go to `front-end` repo to contribute instead.
https://operationcode.org
MIT License
101 stars 223 forks source link

Add CivicX image to press page #1014

Closed hollomancer closed 5 years ago

hollomancer commented 5 years ago

Feature

Why is this feature being added?

Operation Code recently graduated from the CivicX accelerator and we'd like to put our graduation badge on the press page!

What should your feature do?

Please add the CivicX image (attached) to the bottom of the page, with a link to http://cvcx.org/veterans-solutions-lab/

copy of copy of civicx_stamp_final_backed

Jacfem commented 5 years ago

@hollomancer I'm interested in tackling this one if it's free! I do have a couple of questions:

Where exactly are you picturing it placed near the bottom of the page? Should it be under the Branding section, and if so, should there be a new white background behind it (rather than the grey background for Branding)? Or were you picturing this sitting near the Photos section and before the Branding section?

Also, do you have any preference on an alt tag for the image?

Thank you in advance!

kylemh commented 5 years ago

The alt tag should represent text that describes the image to somebody hard of sight.

Something like: "Badge indicating being an approved graduate of CivicX Accelerator"

I won't speak to where exactly Conrad would like it.

hollomancer commented 5 years ago

Maybe "Operation Code is a graduate of the CivicX Accelerator."

Probably at the very bottom of the page, below the footer.

Jacfem commented 5 years ago

@kylemh @hollomancer Thank you both! I just opened a PR for this, would love to get your feedback on the conditional approach I took, to make sure it aligns with any patterns you'd like to be using.

hollomancer commented 5 years ago

Apologies, I should have said above the footer... not enough coffee ☕️

In order to explain better, we can add the text above; "Operation Code is a graduate of the following startup accelerators:"

Jacfem commented 5 years ago

@hollomancer Haha, no problem - I totally get that! I just updated the PR with all of that, thanks!