OperationCode / operationcode_frontend

Front-end repository for live site. Please go to `front-end` repo to contribute instead.
https://operationcode.org
MIT License
101 stars 223 forks source link

Fix misspelling on history page for Techstars #1018

Closed hollomancer closed 5 years ago

hollomancer commented 5 years ago

Bug Report

What is the current behavior?

Text reads: Molina joins Techstar's Patriot Boot Camp (PBC) at

What is the expected behavior?

Text reads Molina joins Patriot Boot Camp (PBC), presented by Techstars, at

Jacfem commented 5 years ago

@hollomancer Looking to get involved in the repo, I can take this one!

kylemh commented 5 years ago

@Jacfem - I've assigned myself as a placeholder for your work. Feel free to DM me on Slack if you'd like some help šŸ˜„

Jacfem commented 5 years ago

@kylemh Thanks! My one question is what we still want to be the anchor tag - Could you let me know which of these two options?

1:

screen shot 2018-08-03 at 5 36 46 pm

2:

screen shot 2018-08-03 at 5 37 31 pm
kylemh commented 5 years ago

Great question. I think Iā€™d prefer option #2

Jacfem commented 5 years ago

@kylemh Before I open a PR, I noticed in my pushed branch a much larger diff than what I actually changed - it seems there are some pre-push linting hooks that are auto-formatting the file I touched - I didn't see anything about that in the Contributing doc, so is that expected and/or good?

Thank you for your help!

kylemh commented 5 years ago

Yup yup!

"lint-staged": {
    "*.{js,json}": ["prettier-eslint --write", "git add"],
    "*.css": ["stylelint --fix", "git add"]
  }

Any files you've changed will get linted in their entirety.

We should probably run a repo-wide format, but we haven't. Feel free to PR šŸ‘

Jacfem commented 5 years ago

@kylemh sweet, thanks for the clarification! PR here