OperationCode / operationcode_frontend

Front-end repository for live site. Please go to `front-end` repo to contribute instead.
https://operationcode.org
MIT License
101 stars 221 forks source link

Render CivicX Badge on Press page #1022

Closed Jacfem closed 6 years ago

Jacfem commented 6 years ago

Description of changes

-Adds the CivicX image below the footer on the Press page, per the request in this Issue. -Also removes some conflicting footer height rules, and addressed some linting warnings.

screen shot 2018-08-05 at 4 31 46 pm screen shot 2018-08-05 at 4 48 26 pm screen shot 2018-08-05 at 4 48 45 pm

Issue Resolved

Fixes #1014

kylemh commented 6 years ago

Let’s get this at the bottom of the actual press page instead. Above the footer.

Jacfem commented 6 years ago

@kylemh Cool, I think it would look more logical there as well. Before I push the change, wanted to point out that this is how it would look on mobile and desktop, respectively. Would you be interested in me removing the min-height: 250px from the Branding section? It would then look like the second set of pictures. No worries if not, I just thought it looked like a bit too much empty space.

Mobile

screen shot 2018-08-05 at 6 27 02 pm

Desktop

screen shot 2018-08-05 at 6 28 09 pm

Mobile with collapsed space

screen shot 2018-08-05 at 6 27 13 pm

Desktop with collapsed space

screen shot 2018-08-05 at 6 28 40 pm
kylemh commented 6 years ago

@Jacfem

I wasn't thinking ahead on this issue, but now that the PR is open, I've chatted with Conrad and we have a clear picture of what we'd like for now.

Let's try to implement it like this: screen shot 2018-08-05 at 5 14 08 pm

kylemh commented 6 years ago

RE: Removing minimum height.

I don't think it's worth the effort, but you're welcome to make the change to height: auto with no min-height. Please do not change the Section component and do not use !important

Jacfem commented 6 years ago

@kylemh No problem, thanks for all the clarification! I believe I've addressed everything - regarding the thought around removing the hard-coded min-height, I decided it seems out of scope for this and I made no changes there.

Let me know if anything else should be addressed, thank you!

Jacfem commented 6 years ago

Updated pictures:

screen shot 2018-08-06 at 7 35 20 pm screen shot 2018-08-06 at 7 37 00 pm
kylemh commented 6 years ago

Looks great toe me!

hollomancer commented 6 years ago

LGTM!