Created 'Get involved' page -- need some help

[ksmacleod99]

Description of changes

Makes a Get Involved page

Issue Resolved

Satisfies Issue #12

Needs review; and I don't know how to begin with the styles for the isLeftFocused, isRighFocused, etc booleans. Needs path to volunteer page. Also, some storybook info got sucked up into a commit, please advise on how to remove (or fix so it works properly :D )

[jjhampton]

@ksmacleod99 re: 'some storybook info got sucked up into a commit, please advise on how to remove' - perhaps you ran one of the storybook NPM scripts while developing. I've noticed that this has a tendency to add (unwanted) changes that will be committed to Git.

The offending commit appears to be 73977cabc91 . Since you've already submitted this PR and others may have pulled in this code to collab/review it, I would run git revert 73977ca. This will add a new commit that reverses the changes made in 73977ca. Then push the new (reverting) commit up to your remote branch.

The other option would be to use git's interactive rebase feature to delete commit 73977cabc91 (which rewrites history), and then git push --force to update your remote branch with the new version of history. Only do that if you're sure that no one else has pulled in your earlier changes.

[ksmacleod99]

@jjhampton I think I did it... how bad did I break it?

[jjhampton]

@ksmacleod99 It looks like your revert commit got rid of some of the unwanted Storybook-related changes from commit 73977ca, but not all of them. The other files that have unwanted Storybook-related changes (and should have changes reversed by git revert) are:

• .storybook/config.js
• .storybook/webpack.config.js
• stories/index.stories.js
• yarn.lock

If you run git revert 73977ca again, I'd suggest inspecting the revert commit afterwards to ensure that the above files have the Storybook-related changes removed (by running git diff HEAD^, or possibly by using a Git GUI tool such as the GitHub desktop app or GitKraken). Once you are sure that those files have the Storybook-related changes removed, you can push again to your remote.

[ksmacleod99]

If the story book commits are gone, it should be good to go. I can work on isLeftFocus/isRightFocus on a different PR.

[jjhampton]

@ksmacleod99 This one's been open for quite some time now - how's it coming along? Do you need any help getting this finished up?

[ksmacleod99]

I have everything except the redirect and the dangling underscore

[jjhampton]

@ksmacleod99 @wimo7083 @kylemh I've pushed up some more changes and feel this is ready to review/merge. Page is accessible at http://localhost:4000/get-involved if you pull down this PR branch.

Updates:

• DRY'ed up the CSS
• Used our reusable Section component within the sub-sections of Get Involved page
• Cleaned up mobile responsiveness
• Removed propTypes variables and unused proptypes
• Set the HeroBanner height on desktop component to 480px - consistent w/ our already-in-use QuoteBanner and family banner on the About page
• Removed the SuccessStories component from this page - as noted in #12 discussion, it's already on the landing page, which should have priority over this page.

After this is merged, we can work on the following. I'll create new issues as needed:

• Continue work on the shared HeroBanner component to make it reusable for other pages / background images. The component doesn't yet support passing in props for left/right/center alignment yet, or props for a dynamic classname, but we can add that next and start using it elsewhere in the app. It works fine on the Get Involved page for now.
• Figure out how we'll navigate/link to this page (from nav or elsewhere in app) - an issue needs to be created for that and several of our other new pages which have the same problem
• Add redirects to home.js for multi-word-route names (as @kylemh suggested here).