OperationCode / operationcode_frontend

Front-end repository for live site. Please go to `front-end` repo to contribute instead.

https://operationcode.org

MIT License

101 stars 222 forks source link

Responsive YouTube Embed #900

Closed tskuse closed 6 years ago

tskuse commented 6 years ago

Description of changes

Modifies TriGroup to responsively display the embedded YouTube video for mobile devices.

Tested in Chrome, Firefox, and Chrome for Android.

screenshot from 2018-03-10 17-08-32

jjhampton commented 6 years ago

@tskuse In my opinion, the 'Join Us' and 'Donate Now' buttons would look better if they were both below the video (on mobile screens) instead of book-ending it vertically. Might be able to use flexbox order style to achieve this w/ media queries.

jjhampton commented 6 years ago

@tskuse Other than that requested change, this looks really good on my Android device. I also like how the video fluidly resizes as I decrease my screen size on my laptop. It's a lot better than just hiding the video outright.

tskuse commented 6 years ago

Thanks for the feedback. I've committed the change for the buttons.

screenshot from 2018-03-10 20-54-54