search

OperationCode / operationcode_frontend

Front-end repository for live site. Please go to `front-end` repo to contribute instead.
https://operationcode.org
MIT License
101 stars 222 forks source link

Fix image sources for partner schools #913

Closed kylemh closed 6 years ago

kylemh commented 6 years ago

Description of changes

Changes to functional component and uses GitHub API to fetch images

Issue Resolved

Fixes #912

kylemh commented 6 years ago

@hpjaj lemme know if is_partner is a boolean you'd ever consider adding to our endpoint. In the past we said no because we assumed it would be changing data. We rarely seem to remove partner schools.

hpjaj commented 6 years ago

@kylemh - Are there other filtering options that we would like to have available to us now or soon, for the CodeSchool table, that we've been holding off on?

If yes, I would prefer to add tagging functionality to the CodeSchool table, similar to what we are doing with Resource:

https://operationcodeapi.docs.apiary.io/#reference/0/resource-collection/list-all-resources

Tagging might slow down the query X milliseconds (NBD); however, it makes things more flexible for us, moving forward.

It is a small table, with not too many attrs, so it is not a huge deal either way.

kylemh commented 6 years ago

@hpjaj it'd likely just be this.

hpjaj commented 6 years ago

@kylemh - https://github.com/OperationCode/operationcode_backend/issues/275