OperationCode / operationcode_frontend

Front-end repository for live site. Please go to `front-end` repo to contribute instead.

https://operationcode.org

MIT License

101 stars 222 forks source link

Add precommit linting #925

Closed kylemh closed 6 years ago

kylemh commented 6 years ago

Description of changes

Ditch lesser-known pre-commit module for widely-touted husky library
Utilize lint-staged library to decrease pre-commit script time (only runs on staged files)
Create scripts for future use in code-wide formatting (future PRs incoming)
Update lint-related dependencies
Edit .eslintrc
Implement .stylelintrc
Make in-IDE lint fixes on only the files absolutely necessary to build the front-end.

Issue Resolved

Fixes #915 Fixes #916

kylemh commented 6 years ago

Going to hold off on any code-base wide lint fixes until the social logins PR is finished, but I couldn't avoid these style fixes.

Once merged / if you're testing this branch locally, I highly recommend running a clean clone/install to avoid cached git hooks from the previous devDependency and to avoid cached node_modules version discrepancies.