Closed NestorSegura closed 6 years ago
@NestorSegura thanks for taking this issue on. I pulled the changes locally, but I expected the layout on desktop to match the mocks within the issue
https://projects.invisionapp.com/share/W4GAP27J79S#/screens/284569928
https://projects.invisionapp.com/share/BVGB6BLAG7T#/screens/282720967
Is this a work in progress?
Hi @kylemh, I matched the one with the white background, but now I see there are 4 options, should the text iterate in some way? or which one should I implement? what are you missing in the design ? I didn't change the colors as I think this would be part of a new issue as you said.
@NestorSegura which 4 are you speaking of? The links I included are one design with an appearance of mobile and desktop.
@kylemh I think he's referring to the 4 different versions (different color schemes) that you can see by pressing left/right w/ arrow keys on the desktop design. We probably should have clarified which one to work on before asking for people to start work on this issue. Sorry about the lack of clarity @NestorSegura .
that's right @jjhampton, I didn't see the 4 diferent design options at first, so I Implemented also the first one, I will also implement the changes suggested and make a further pull request for it. I think, as there isn't clear how to continue about the color cheme of the brand, it will be better to set the new design without any new colors but with the new layout. what do you think? the other designs suggest also other background colors.
I had never clicked left or right on my keyboard when viewing the Invision slides 🤦♂️ ... The layout of #1/#4 should be fine
@NestorSegura precisely. The new layout, but without the color changes 👍
@NestorSegura Thanks for making that last batch of changes! Looking really good. I'm going to fix merge conflicts and push up a few more small changes to this branch, and I think we'll be ready to merge at that point.
@kylemh I pushed up some changes - please pull and run this PR branch if you have the time. Feel free to adjust and commit up any stylistic changes you feel necessary.
Screenshot:
LGTM, saw a weird console bug when running it. Went ahead and fixed it. Nice job.
Description of changes
add hero section to /landing, and implemented the redesign in it for hero section, addapt the landing/landing to the new component and delete /triGoup, add /adBanner functionality to acept other classes to manage background and other styles, add bordered button to /linkButton component.
Issue Resolved
Fixes #920