search

OperationCode / operationcode_frontend

Front-end repository for live site. Please go to `front-end` repo to contribute instead.
https://operationcode.org
MIT License
101 stars 222 forks source link

Creates OpCodeCon #937

Closed ksmacleod99 closed 6 years ago

ksmacleod99 commented 6 years ago

Description of changes

creates branch & component, adds route to home.js. It's ugly but it's a placeholder.

Issue Resolved

new feature/page

jjhampton commented 6 years ago

The word 'Click' in this sentence is very hard to see due to the gray color and how it overlaps the background image. An easy fix would be to get rid of this sentence altogether - when we have more details on the convention, we can add them. selection_039

apex-omontgomery commented 6 years ago

Worked on a few changes. One thing I noticed is that at a certain zoom level amount the text becomes hard to read and I'm not sure what to do with the repeated background image. image

apex-omontgomery commented 6 years ago

@ksmacleod99 hope you don't mind me playing around and doing some of the changes. I really like the image you used, and I think the image stitches well together horizontally without you really noticing.

jjhampton commented 6 years ago

Thanks for the fixes @wimo7083 . I added some CSS styles in media queries so the text will be more aligned to the top-left (out of the way of the buildings), and also so some of the city skyline can be seen on mobile. I also set the background-size to always be 100% at screen-width of 1200px and above, which should eliminate the stitching/repeating issue that you posted in the earlier screenshot.

Please feel free to continue pushing up tweaks, or merge when deemed ready. ping @ksmacleod99

Desktop:

selection_040

Mobile:

selection_041

jjhampton commented 6 years ago

Merged on approval from @ksmacleod99