search

OperationCode / operationcode_frontend

Front-end repository for live site. Please go to `front-end` repo to contribute instead.
https://operationcode.org
MIT License
101 stars 222 forks source link

Fix Launch School image & use S3 URLs for partnered school logos #951

Closed jjhampton closed 6 years ago

jjhampton commented 6 years ago

Bug Report

What is the current behavior?

Launch School partnered school card on www.operationcode.org/code_schools shows the logo for Launch Code (wrong logo). The logo URLs in the PartnerSchools component are also not using AWS S3 URLs - still referencing GitHub images.

What is the expected behavior?

Correct logo is displayed, and image URLs are sourced from AWS S3.

What steps did you take to get this behavior?

Visit www.operationcode.org/code_schools, click on partner schools

Additional Info

Note - properties for Partner Schools cannot be updated via Admin Dashboard since they are not fetched from the API. Partner schools are still hardcoded in the front-end UI, which is why this is being changed via code in a PR.

kylemh commented 6 years ago

@jjhampton this problem exists for all non-endpoint fetched code school images.

All hero banners, all hard-coded code schools (moocs too)

https://github.com/OperationCode/operationcode_frontend/issues/931

jjhampton commented 6 years ago

@kylemh Cool - maybe we can go through and update all Hero images and MOOCs in another swoop. I really want to get at least the partner schools correct, especially since we're displaying the wrong logo for a partner school (Launch School).