search

OperationCode / operationcode_frontend

Front-end repository for live site. Please go to `front-end` repo to contribute instead.
https://operationcode.org
MIT License
101 stars 222 forks source link

revamped the con page #967

Closed Wimsy113 closed 6 years ago

Wimsy113 commented 6 years ago

Description of changes

The description of changes are as follows: Replaced hero image with a spiffy graphic for the con page, made a sponsorship button as opposed to a link to make it stand out next to the donate button.

Issue Resolved

Fixes #

jjhampton commented 6 years ago

@Wimsy113 I am going to label this as 'Work in Progress' for now (so no one reviews/merges it), I saw your message in Slack that you were still working on it.

Wimsy113 commented 6 years ago

Thanks @jjhampton I appreciate it!

jjhampton commented 6 years ago

Looks pretty good to me at first glance. We'll have to get these images uploaded to S3, since we're now serving assets from there instead of uploading them to GitHub. Either @kylemh or I can do that.

Wimsy113 commented 6 years ago

Okie dokie sounds good. I'm going to keep working on this as I get the info, but for right now this is good to have up so we can start pulling in some donations and sponsors, just let me know if you need me to send the image over or you can pull it from the file, there's a bunch of em cause I was playing with them and I'm probably gonna submit a pr to remove the extra ones we don't need.

ksmacleod99 commented 6 years ago

Hey @Wimsy113, could you please not apply styles directly to HTML elements? It tends to mess up other elements across the site. Make a new class :)

jjhampton commented 6 years ago

I went ahead and adjusted the CSS (changed to class rule instead of element/tag rule) and pushed a couple other fixes. Going to merge after CI build passes.

Great job @Wimsy113 , the new background looks slick!