search

OperationCode / operationcode_frontend

Front-end repository for live site. Please go to `front-end` repo to contribute instead.
https://operationcode.org
MIT License
101 stars 222 forks source link

Only use common link module for all references to our donation link #972

Closed ksmacleod99 closed 6 years ago

ksmacleod99 commented 6 years ago

Feature

Why is this feature being added?

Easy management of donation links across website

What should your feature do?

All extraneous references can be found in this PR: https://github.com/OperationCode/operationcode_frontend/pull/970#pullrequestreview-119688814

Essentially, import commonUrl from 'shared/constants/commonLinks'; at the top of any file linking to a donation page (convert a JSON file into an exported module if need be), and use that. With this done, changing the donation link can simply occur in one place

rishu2482 commented 6 years ago

Hey @ksmacleod99 , Can i pick this up ?

ksmacleod99 commented 6 years ago

Sure thing, @rishu2482! Thank you :)

rishu2482 commented 6 years ago

Thanks. Will submit a PR as soon as possible.

rishu2482 commented 6 years ago

Hey @ksmacleod99 , I have moved below urls(mentioned in #970) to constant and other required changes. https://secure.lglforms.com/form_engine/s/BRtP7QUKyHOyEYsZROsRew https://secure.lglforms.com/form_engine/s/L428AQ2rrsFJQyy5Fbglvg

Raised a pull request. Please review it and let me know if any thing else required.