search

OperationCode / operationcode_frontend

Front-end repository for live site. Please go to `front-end` repo to contribute instead.
https://operationcode.org
MIT License
101 stars 222 forks source link

Issue#936 #984

Closed erathinam closed 6 years ago

erathinam commented 6 years ago

Description of changes

Added a Notification modal that displays a message to upgrade the browser when IE 11 or less is being used.

Issue Resolved

Fixes #936

kylemh commented 6 years ago

A few fixes suggested! Good work.

erathinam commented 6 years ago

@jjhampton Thanks for reviewing, making the changes and merging. I would like to ask one more question. Is there any documentation available for understanding the S3 architecure. Basically i want to understand why are we moving the images separately to S3 and the process of our app getting deployed.

Thanks.

hollomancer commented 6 years ago

@ohaiwalt, can you shed some light on this piece?

jjhampton commented 6 years ago

@erathinam We've made a decision to move static assets to AWS S3 instead of hosting them all on GitHub - this is explained in #931.

Currently, only maintainers with access to our S3 buckets can add assets there. We don't have this process documented specifically for Operation Code, but for S3 in general, there should be plenty of docs for it at https://aws.amazon.com/s3/ .

kylemh commented 6 years ago

@erathinam you seem to be learning quite a bit! I'm in the process of recreating this repository with best practices, a more rigid test system, and supporting tools in https://github.com/OperationCode/front-end

I ended up refactoring your component a bit. It has a nearly identical appearance, but I thought you'd be interested in seeing how I would've implemented your component. https://github.com/OperationCode/front-end/tree/master/common/components/UpgradeBrowserOverlay

Lastly, do you mind sharing how you feel about your experience contributing to Operation Code? Are there areas you think we can improve upon, and do you think we should continue certain practices?

erathinam commented 6 years ago

@jjhampton Thanks for sharing that info and thread. @kylemh I saw your implementation and the code looks great. Very well structured and i got to know certain things i could have done it better.

My experience contributing to Operation Code was fantastic. Since i am new to reactJS, my basic idea was to learn techniques and ideas on how advanced developers do and this is something, i am learning day by day. Also, i felt the team is more quick in responding to any queries i have.

About the things that the team can improve open , i don't have any points since i am a newbie but maybe i will get a good grasp and give feedbacks in the future. I'm happy that i chose OpCode to contribute. :)