Closed irvingpop closed 3 years ago
@irvingpop looks like it failed CI because it couldn't install a dnsimple plugin. Are we concerned about that or should we merge in spite of failures?
hey @aaron-suarez I noticed that as well. We're at the point now where we aren't really using any of the Terraform<->DNSimple stuff anyway.
My preference would be to start cleaning it up in a future PR, but I'm open to the idea of at least removing those CI checks in this PR so it's green. what do you think?
I'm fine merging it now and fixing it in a new PR. No need to drag it out if we're not using the functionality anyway. Ready for me to merge?
let's do it!
This PR is purely to sync our codebase with reality. These updates are already tested and deployed out to our cluster.
Signed-off-by: Irving Popovetsky irving@honeycomb.io