search

OperationCode / operationcode_old_site

Our open source website. We're on a mission to help the military community learn software development, enter the tech industry, and code the future.
https://www.operationcode.org/
MIT License
229 stars 155 forks source link

Style the flash message and separate color variables to separate partial #566

Closed mwagz closed 7 years ago

mwagz commented 7 years ago

This PR will style the flash message to be a little more intentional. I have also separated the color variables in application.css.scss to a new partial, _colors.scss. This should allow us to maintain a better brand usage.

Relates to #296.

Old Screenshot

screenshot 2016-11-12 23 50 55

New Screenshot

screenshot 2016-11-13 00 04 40
rickr commented 7 years ago

Hi @mwagz. Thanks for the PR it looks great! Are you able to clean up these few hound errors?

mwagz commented 7 years ago

Yup. I sure can. I'll create a colors file to store the color variables in. I'll need to do some digging on the high rule count. The rest shouldn't be a problem. Sorry for the delay. Got pulled away on another project.

mwagz commented 7 years ago

@rickr I've cleaned up the hound errors. and pushed the color declarations into a separate _colors.scss file.

rickr commented 7 years ago

Awesome work. Thanks!