search

OperationCode / operationcode_old_site

Our open source website. We're on a mission to help the military community learn software development, enter the tech industry, and code the future.
https://www.operationcode.org/
MIT License
229 stars 155 forks source link

Issue #588 added favicons for all devices #589

Closed Kornil closed 7 years ago

Kornil commented 7 years ago

Included code on for all devices that require a special .png format.

made a new favicon.ico file with 16x16 24x24 32x32 48x48 and 64x64 px .png included(for all desktop browsers).

On metro tile the logo has a white background.

Kornil commented 7 years ago

Hi @rickr thanks for your suggestion, but I'm a bit confused, do you want me to format the link tags like this:

<link href="/assets/myicon.ico" rel="shortcut icon" type="image/x-icon" />

and simply using /assets as folder? I'm quite new with ruby and rails so forgive me if this is an obvious question, I want to be sure I'll do the right thing.

Francesco

rickr commented 7 years ago

This is a rails ERB file which means it can include ruby to be executed.

The method documented here allows us to create favicon tags dynamically while using rails' asset pipeline.

I think something like favicon_link_tag 'favicon/apple-touch-icon-57x57.png', rel: 'apple-touch-icon-precomosed', type: 'image/png', sizes: '57x57' might work.

rickr commented 7 years ago

Hello @Kornil,

Are you going to be able to get to these changes?

rickr commented 7 years ago

Closing due to inactivity. Please feel free to reopen when you're able to make the requested changes!