Closed hd719 closed 7 years ago
@hpjaj @rickr I have made changes from above please let me know what you think. If anything is wrong I will def. fix it asap.
Also one more thing in the codeschool.yml
file can I add the bootcamp that I have attended Bloc. They also give out veteran scholarships Bloc Veterans.
-Thank you.
@hd719 - I am just a member of the Operation Code community, I don't have reviewer permissions, for merging. Was just doing a some code reviews to provide feedback.
Ironically, though, I also went to Bloc.io 🙂
@hpjaj It is always a pleasure to meet a fellow Bloc alumni!
It also looks like codeclimate picked up a few new issues. Can you please address those as well?
Hey @rickr I moved some of the logic from the code_school_controller.rb
to the code school's class.
Let me know what you think. Also the codeclimate tests how do you fix the trailing whitespace?
-Thank you.
Hey @rickr any update on this?
@rickr I will fix these changes asap.
Hey @hd719 - it looks like you're all done with the latest fixes - is that the case?
@rickr Hey! so yeah I implemented the latest fixes however for some reasonI cannot get the codeclimate tests to pass.
It looks like a lot of them are little space things: For example this file is missing a new line: https://github.com/OperationCode/operationcode/pull/737/files#diff-5665789a04effed313d97af65082f8feR33
Hey @rickr so for the example did I add the new line correctly?
Okay I fixed most of them lol in the new commit.
Hey @rickr! So the codeclimate issues have been fixed, there is this 1 issue about the content tag, but that was already there from the beginning and I don't know how to fix that.
Also if it is okay with everyone can I add my self to contributors.md
file?
You can definitely add yourself to contributors.md - looks like Codeclimate caught one more thing though.
Hey @hollomancer good to hear from you.
It says Unescaped model attribute in content_tag
<%= content_tag 'div', nil, id: :'veterans-map', class: :'veterans-map', data: { lat_longs: @lat_longs } %>
I do not know how to fix this error. Any help would def. be appreciated.
-Thank you.
I think the finding might be bogus.
I believe content_tag marks input as html_safe
which in rails means you are sure the content is not malicious. Since we're reviewing the input in a PR I've gone ahead and approved the change anyway.
@hollomancer and @rickr Thank you! It was fun working on this PR glad I could be of help!
Great job. Thanks for all your hard work!
Hello @rickr
I added the map of the codeschools (issue #272).
I also could not add all the coordinates for all the coding bootcamps in the
config/code_schools.yml
file, but I add some just to test out the feature.If I am missing anything please do let me know!
-Thank you.