AmitKarin commented 4 years ago

created a new func change_component_monitoring_mode that sets the monitoring mode for the component.

ItayHoresh commented 4 years ago

@AmitKarin please check why the travis build checks is failing.

codecov[bot] commented 4 years ago

Codecov Report

Merging #90 into master will increase coverage by 0%. The diff coverage is 100%.

@@         Coverage Diff          @@
##           master   #90   +/-   ##
====================================
  Coverage      68%   68%           
====================================
  Files          16    16           
  Lines         975   981    +6     
====================================
+ Hits          664   670    +6     
  Misses        311   311

Impacted Files	Coverage Δ
pipert/core/component.py	`87% <100%> (+<1%)`	:arrow_up:
pipert/core/pipeline_manager.py	`67% <100%> (+<1%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be650d9...bc40fc8. Read the comment docs.

AmitKarin commented 4 years ago

@ItayHoresh all checks are done. can you approve?

ItayHoresh commented 4 years ago

There is still implementation of splunk in pipe manager. It's need to be optional.

AmitKarin commented 4 years ago

@ItayHoresh all the checks are passed and i fixed the import of splunk. can you approve?

OperationalBina / PipeRT

Set monitoring by config #90

Codecov Report