OperationalBina / PipeRT

MIT License
11 stars 7 forks source link

Create a docker-compose file which will run each component in a separate container #96

Closed sionovd closed 4 years ago

sionovd commented 4 years ago

If we'll want to run components in separate containers/pods, then we'll use the same docker image for all of them, but each container would specify a different command to run in the image. The command could look something like this: python -m pipert.core.component --cfg_path <component_cfg_path>

The ability to define the container's command is supported in Kubernetes and in OpenShift.

MayoG commented 4 years ago

Is this issue is about creating the dockerfile for the component ?

Or creating the script that will generate the docker-compose file from the configuration file. but before doing that we should agree on a format for the config file further then what we have know for example, how we specify which components will be on one pod/service and maybe some other things.

We can make an example of a docker-compose file first and see that the new design will actually work. Is that what this issue is about ?

sionovd commented 4 years ago

We wont need to change the dockerfile - this issue is about adding an alternative docker-compose file which deploys the pipeline using multiple containers, each one containing a different component, instead of one container that contains the whole pipeline.

MayoG commented 4 years ago

But why we are making it ? because of this ?

We can make an example of a docker-compose file first and see that the new design will actually work. Is that what this issue is about ?

sionovd commented 4 years ago

Yep :)