OperationalBina / PipeRT2

Real-time pipeline for video analytics. V2
MIT License
4 stars 3 forks source link

PIPE-111 Fix/pipe created first #139

Closed tomerdayan168 closed 2 years ago

tomerdayan168 commented 2 years ago

I chose to create new 'GET' route to return the pipe's structure. One of the reasons we can't reuse the send_initial_log it's because while the pipe is running, a multiple logs are sending and in the send_initial_log function there is a change of the log name to creation log name, where regular logs can send with this log name and cause multiple exceptions. I reused the way we create the initial log, but not the way we send it to the cockpit. So new function with new route, and without any dependencies it's the best solution I came up with.

codecov[bot] commented 2 years ago

Codecov Report

Merging #139 (1e22c27) into develop (88b866b) will decrease coverage by 1%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #139   +/-   ##
======================================
- Coverage       96%    95%   -2%     
======================================
  Files           60     60           
  Lines         1187   1230   +43     
======================================
+ Hits          1148   1175   +27     
- Misses          39     55   +16     
Impacted Files Coverage Δ
pipert2/core/base/pipe.py 98% <100%> (+<1%) :arrow_up:
pipert2/core/wrappers/api_wrapper.py 97% <100%> (+<1%) :arrow_up:
pipert2/core/handlers/message_handler.py 58% <0%> (-42%) :arrow_down:
pipert2/utils/publish_queue.py
pipert2/utils/queue_wrapper.py
pipert2/utils/queue_utils/queue_wrapper.py 97% <0%> (ø)
pipert2/utils/queue_utils/publish_queue.py 94% <0%> (ø)
...t2/core/handlers/message_handlers/queue_handler.py 97% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88b866b...1e22c27. Read the comment docs.